Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules-control-panel.adoc #476

Open
wants to merge 1 commit into
base: 2.5.x
Choose a base branch
from

Conversation

ZacharyKlein
Copy link

Indicate how to add the control panel module

Indicate how to add the control panel module
Copy link
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I would however prefer that we have an intro explaining what this snippet is about. In particular, we don't document the integration with Gradle or Maven plugins in that doc.

A couple suggestions:

Ideally, for the Gradle snippets, you should use KnownModules.CONTROL_PANEL, not the string.

@sdelamo
Copy link
Contributor

sdelamo commented Feb 2, 2024

@alvarosanchez @melix should should add this to starter when someone adds control-panel feature? https://github.com/micronaut-projects/micronaut-test-resources/pull/476/files

@melix
Copy link
Collaborator

melix commented Feb 2, 2024

That's the control panel for the test resources module itself. So you could use the control panel in test resources without using control panel in your own app and vice-versa. Maybe the easiest is actually to include the control panel by default in starter when test resources are enabled, it's useful anyway.

@alvarosanchez
Copy link
Member

include the control panel by default in starter when test resources are enabled

This is what I agree with

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants